feat(turbopack-ecmascript): cache external modules with wrapper #7988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
ForsakenHarmony
force-pushed
the
hrmny/pack-2622-cache-external-modules-during-evaluation
branch
from
ba5e20a
to
03aa0ca
Compare
ForsakenHarmony
force-pushed
the
hrmny/pack-2622-cache-external-modules-during-evaluation
branch
from
03aa0ca
to
47b73f5
Compare
ForsakenHarmony
force-pushed
the
hrmny/pack-2622-cache-external-modules-during-evaluation
branch
from
47b73f5
to
0f1b8c6
Compare
ForsakenHarmony
force-pushed
the
hrmny/pack-2622-cache-external-modules-during-evaluation
branch
from
0f1b8c6
to
8e33ac1
Compare
ForsakenHarmony
force-pushed
the
hrmny/pack-2622-cache-external-modules-during-evaluation
branch
from
8e33ac1
to
23a64a6
Compare
ForsakenHarmony
force-pushed
the
hrmny/pack-2622-cache-external-modules-during-evaluation
branch
from
64c6040
to
9613e68
Compare
ForsakenHarmony
force-pushed
the
hrmny/pack-2622-cache-external-modules-during-evaluation
branch
from
9613e68
to
61b9af3
Compare
kdy1
approved these changes
Jun 10, 2024
sokra
approved these changes
Jun 10, 2024
ForsakenHarmony
force-pushed
the
hrmny/pack-2622-cache-external-modules-during-evaluation
branch
from
61b9af3
to
be2e189
Compare
ForsakenHarmony
deleted the
hrmny/pack-2622-cache-external-modules-during-evaluation
branch
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jun 10, 2024
### What? This is a fix for a bundle potentially referring to two different external modules (e.g. `react` because it gets invalided from the require cache) See vercel/turborepo#7988 ### Turbopack Updates * vercel/turborepo#8376 <!-- Tim Neutkens - Rename ChunkLoading::None to ChunkLoading::Edge --> * vercel/turborepo#8371 <!-- Donny/강동윤 - test: Add an execution test for `paren_remover` --> * vercel/turborepo#8370 <!-- Tobias Koppers - Tree Shaking shared state and side effects --> * vercel/turborepo#7988 <!-- hrmny - feat(turbopack-ecmascript): cache external modules with wrapper --> Closes PACK-2622
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
This is a fix for a bundle potentially referring to two different external modules (e.g. `react` because it gets invalided from the require cache) See vercel/turborepo#7988 * vercel/turborepo#8376 <!-- Tim Neutkens - Rename ChunkLoading::None to ChunkLoading::Edge --> * vercel/turborepo#8371 <!-- Donny/강동윤 - test: Add an execution test for `paren_remover` --> * vercel/turborepo#8370 <!-- Tobias Koppers - Tree Shaking shared state and side effects --> * vercel/turborepo#7988 <!-- hrmny - feat(turbopack-ecmascript): cache external modules with wrapper --> Closes PACK-2622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New attempt at adding this after reverting 🙃